Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pull in serde_with_macros #27

Merged
merged 2 commits into from Aug 12, 2021

Conversation

puiterwijk
Copy link
Contributor

This patch disables the default features for serde_with, which pulls in
its macros feature.
This expands the dependencies farther than we need, since we don't use
the macros at all.

Signed-off-by: Patrick Uiterwijk patrick@puiterwijk.org

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the Apache License Version 2.0, as specified in the LICENSE file of this repository.

This patch disables the default features for serde_with, which pulls in
its macros feature.
This expands the dependencies farther than we need, since we don't use
the macros at all.

Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
@puiterwijk
Copy link
Contributor Author

A fix for the Clippy needless borrows is in #21.

@petreeftime petreeftime merged commit 699aa93 into awslabs:main Aug 12, 2021
@puiterwijk puiterwijk deleted the no_cargo_with_macros branch August 12, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants