Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated README for lambda_http #554

Merged
merged 6 commits into from Oct 24, 2022
Merged

Conversation

ymwjbxxq
Copy link
Contributor

@ymwjbxxq ymwjbxxq commented Oct 22, 2022

Issue #, if available:
#498

Description of changes:
The README that we add to lambda_http when we publish the crate is the same as we use for the runtime. This readme is too generic to be useful to users. We should create a new README specific for lambda_http that talks about the features in this crate, and how to use it, instead of the generic runtime.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this new readme, I really appreciate it. In order to use it when we publish new versions, you need to update lambda-http/Cargo.toml replacing the location of the readme file.

lambda-http/README.md Show resolved Hide resolved
lambda-http/README.md Outdated Show resolved Hide resolved
lambda-http/README.md Outdated Show resolved Hide resolved
lambda-http/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just one missing mention to Lambda Function URLs. I think it'll be good to go when that's addressed.

lambda-http/README.md Show resolved Hide resolved
@calavera calavera merged commit f8706e3 into awslabs:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants