Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export external modules of publicly used types #542

Merged
merged 1 commit into from Oct 8, 2022
Merged

Re-export external modules of publicly used types #542

merged 1 commit into from Oct 8, 2022

Conversation

dcormier
Copy link
Contributor

@dcormier dcormier commented Oct 7, 2022

Some types that were used publicly were not re-exported, in some cases, making things more difficult for consumers. This change re-exports modules that were missing from being re-exported (several crates/modules already were re-exported).

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

calavera
calavera approved these changes Oct 8, 2022
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea 👍

@calavera calavera merged commit 45211b0 into awslabs:main Oct 8, 2022
@dcormier dcormier deleted the dc/expose branch October 10, 2022 13:11
@dcormier dcormier mentioned this pull request Oct 10, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calavera calavera calavera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dcormier @calavera