Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Adapter to be .boxed() #540

Merged
merged 1 commit into from Oct 11, 2022
Merged

Allow Adapter to be .boxed() #540

merged 1 commit into from Oct 11, 2022

Conversation

dcormier
Copy link
Contributor

@dcormier dcormier commented Oct 6, 2022

Allowing Adapter to be .boxed() enables easier composition of tower::Services that may include additional middleware prior to Adapter converting the LambdaEvent to a Request.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@dcormier
Allow Adapter to be .boxed()
7abff0c 
Allowing `Adapter` to be [`.boxed()`](https://docs.rs/tower/0.4.13/tower/trait.ServiceExt.html#method.boxed) enables easier composition of `tower::Service`s that may include additional middleware prior to `Adapter` converting the `LambdaEvent` to a `Request`.
@calavera
Copy link
Contributor

calavera commented Oct 7, 2022 •
edited

This probably needs a minor release since it could be a breaking changes. I would imagine all futures are already Send, but it's better to be cautious. I'm going to leave it here without merging it for now, so @bnusunny has time to look into it too.

bnusunny
bnusunny approved these changes Oct 8, 2022
View reviewed changes
Copy link
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calavera calavera merged commit 1e16502 into awslabs:main Oct 11, 2022
@dcormier dcormier deleted the dc/send branch October 11, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calavera calavera calavera approved these changes

@bnusunny bnusunny bnusunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dcormier @calavera @bnusunny