Add custom response header to force text encoding #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to force text encoding on responses that the runtime doesn't consider text and would return binary data otherwise. Signed-off-by: David Calavera <david.calavera@gmail.com>
bnusunny
approved these changes
Sep 20, 2022
Comment on lines
+204
to
+209
| if let Some(value) = headers.get(X_LAMBDA_HTTP_CONTENT_ENCODING) { | ||
| if value == "text" { | ||
| return convert_to_text(self, content_type); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Once this header is set to 'text', the response will be treated as text response. If a web app returns both text and binary data, it has to set this header based on the type of data returned. This seems to put more work on the web app developers.
There was a problem hiding this comment.
Would it be possible to use the lambda_http::Body to set this behind the scenes?
There was a problem hiding this comment.
Yes, you can directly use lambda_http::Body to indicate text or binary response. This is for generic http::Body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to force text encoding on responses that the runtime doesn't consider text and would return binary data otherwise.
I thought about adding some kind of configuration, but I think this is more straightforward to help people in cases where we don't return text responses and they would expect text.
Signed-off-by: David Calavera david.calavera@gmail.com
Issue #, if available:
Follow up to #531
By submitting this pull request