chore: update xmldom and sass packages #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huawenm
approved these changes
Sep 7, 2022
aniruddhadave
added a commit
that referenced
this pull request
Oct 17, 2022
This reverts commit 64ce951.
aniruddhadave
added a commit
that referenced
this pull request
Oct 17, 2022
* Revert "Resolve vulnerable packages of parse-url and d3-color (#586)" This reverts commit cf396b7. * Revert "chore: update xmldom and sass packages (#550)" This reverts commit 64ce951. * Revert "chore: update additional npm packages (#548)" This reverts commit 9826fa0. * Revert "chore: update npm packages (#541)" This reverts commit b669925. * tests: fix utils unti tests * fix: fix null checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
switch node-sass to sass as node-sass is deprecated: https://www.npmjs.com/package/node-sass
resolve xmldom update issue by upgrading to version 0.7.0. From their github: "Since version 0.7.0 this package is published to npm as @xmldom/xmldom and no longer as xmldom, because xmldom/xmldom#271."
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.