BREAKING CHANGE: Convert preferred anti-affinity to required anti-affinity #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jonathan-innis
force-pushed
the
required-anti-affinity
branch
2 times, most recently
from
162ce3f
to
27b912e
Compare
jonathan-innis
changed the title
jonathan-innis
force-pushed
the
required-anti-affinity
branch
5 times, most recently
from
4c1a92c
to
d6ef908
Compare
ellistarn
previously approved these changes
Mar 7, 2023
jonathan-innis
force-pushed
the
required-anti-affinity
branch
from
d6ef908
to
dea9bab
Compare
jonathan-innis
force-pushed
the
required-anti-affinity
branch
from
dea9bab
to
1268b4f
Compare
njtran
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
controller_runtimemetric namespace kubernetes-sigs/karpenter#225 which breaks existing metrics that were running as singleton metrics and moves them to thecontroller_runtimenamespace i.e.deprovisioning_controller_...,provisioning_controller..., etc.How was this change tested?
make applyDoes this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.