Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsii): excessive overrides declarations registered #3375

Merged
merged 3 commits into from Feb 9, 2022
Merged

fix(jsii): excessive overrides declarations registered #3375

merged 3 commits into from Feb 9, 2022

Commits on Feb 9, 2022

  1. fix(jsii): excessive overrides declarations registered 

    Members inherited from parent base classes, which also implemented a
locally implemented interface member, would get tagged with the
`overrides` marker for the interface, which was incorrect, since the
declaring type did not implement the interface directly.

This is solved by passing the inherited members by-copy to the
validator, so side effects of it aren't visible to the final assembly.
    @RomainMuller
    RomainMuller committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    99e5724 View commit details
    Browse the repository at this point in the history

  2. actually remove colors from jsii-tree tests

    @RomainMuller
    RomainMuller committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    4e1f3db View commit details
    Browse the repository at this point in the history

  3. fix snapshot

    @RomainMuller
    RomainMuller committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    75b7ddd View commit details
    Browse the repository at this point in the history