Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dontet): excessive overrides generated #3355

Merged
merged 2 commits into from Jan 31, 2022
Merged

fix(dontet): excessive overrides generated #3355

merged 2 commits into from Jan 31, 2022

Commits on Jan 31, 2022

  1. fix(dontet): excessive overrides generated 

    A mis-understanding of the jsii specification early on was carried over
in the .NET code generators until now, which caused all methods and
properties that are overrides (of other JS implementations) to result in
jsii overrides being registered by the runtime.

This behavior caused unnecessary round-trips between the .NET CLR and
the node sidekick process, which affected the performance of .NET
bindings (unnecessary round-trips with JSON encoding aren't free), and
had a tendency to hit obscure edge case bugs in the jsii kernel's Ser/De
behavior.

This PR removes all `isOverride: true` declarations from generated .NET
code and neutralizes the behavior of specifying it to be true.
User-defined overrides (.NET code overriding JS code) continue to work
as they previously did (the `isOverride` attribute should simply not
have existed, ever).
    @RomainMuller
    RomainMuller committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    362ba1a View commit details
    Browse the repository at this point in the history

  2. fix snapshots

    @RomainMuller
    RomainMuller committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    97ac5cc View commit details
    Browse the repository at this point in the history