Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kernel): kernel's private object annotations are enumerable #3339

Merged
merged 2 commits into from Jan 17, 2022

Commits on Jan 14, 2022

  1. fix(kernel): kernel's private object annotations are enumerable

    The jsii kernel needs to attach metadata to instances that are sent
    across the process boundary. While these properties use symbol names to
    eliminate the risk for collisions with user-defined properties, they
    were inadvertently set as `enumerable`, causing those to show in outputs
    of `JSON.stringify` and to be copied over as part of spat expressions
    (e.g: `{...obj}`), which resulted in the new value sharing the same
    identity as the previous one when sent over the wire.
    
    Caused: aws/aws-cdk#17876
    RomainMuller committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    3ce1374 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Apply suggestions from code review

    Co-authored-by: Nick Lynch <nlynch@amazon.com>
    Romain Marcadier and njlynch committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    cd17e6e View commit details
    Browse the repository at this point in the history