Skip to content

Commit

Permalink
chore: remove integration test from PR validation (#2725)
Browse files Browse the repository at this point in the history
The test is extremely expensive and is performed again in the Code Pipelines used for official releases. It only slows down iteration.
  • Loading branch information
RomainMuller committed Mar 18, 2021
1 parent a830834 commit 90150d5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 142 deletions.
136 changes: 0 additions & 136 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -344,139 +344,3 @@ jobs:
&& echo "Untracked files: ${untracked:-<none>}" \
&& test -z "${untracked}"
shell: bash

integ-test:
name: Integration Test
needs: create-release-package
runs-on: ubuntu-latest

steps:
# Set up all of our standard runtimes
- name: Set up .NET 3.1
uses: actions/setup-dotnet@v1
with:
dotnet-version: '5.0.x'
- name: Set up Go 1.16
uses: actions/setup-go@v2
with:
go-version: '1.16'
- name: Set up Java 8
uses: actions/setup-java@v1
with:
java-version: '8'
- name: Set up Node 10
uses: actions/setup-node@v2.1.5
with:
node-version: '10'
- name: Set up Python 3.6
uses: actions/setup-python@v2
with:
python-version: '3.6'
- name: Install python3-venv
run: sudo apt install -y python3-venv
- name: Checkout aws/aws-cdk
uses: actions/checkout@v2
with:
path: aws-cdk
ref: release
repository: aws/aws-cdk
- name: Download Artifact
uses: actions/download-artifact@v2
with:
name: release-package
path: ${{ runner.temp }}
- name: Locate Caches
id: cache-locations
run: |-
echo "::group::Upgrade pip"
# Need to have PIP >= 20.1 for "pip cache dir" to work
python3 -m pip install --upgrade pip
echo "::endgroup"
echo "::set-output name=pip-cache::$(python3 -m pip cache dir)"
echo "::set-output name=yarn-cache::$(yarn cache dir)"
- name: Cache
uses: actions/cache@v2.1.4
with:
path: |-
${{ steps.cache-locations.outputs.pip-cache }}
${{ steps.cache-locations.outputs.yarn-cache }}
~/.m2/repository
~/.nuget/packages
key: ${{ runner.os }}-node@12-python@3.6-${{ hashFiles('**/yarn.lock', '${{ runner.temp }}/build.json') }}
restore-keys: |-
${{ runner.os }}-node@12-python@3.6-
${{ runner.os }}-node@12-
${{ runner.os }}-
# Run the integration test
- name: Install Dependencies
run: |-
# Python tools used during packaging
python3 -m pip install --upgrade pipx setuptools twine wheel
# TypeScript project dependencies
yarn install --frozen-lockfile
working-directory: aws-cdk
- name: Align Versions
run: |-
# Align versions so we don't build 0.0.0 (it'd fail pack.sh's validation)
./scripts/align-version.sh
working-directory: aws-cdk
- name: Install Tested Packages
run: |-
npm install --no-save ${{ runner.temp }}/js/*.tgz
npm install --no-save ${{ runner.temp }}/private/*.tgz --only=prod
# Setting environment variables for next jobs
echo "JSII=${{ github.workspace }}/node_modules/.bin/jsii" >> $GITHUB_ENV
echo "CDK_BUILD_JSII=${{ github.workspace }}/node_modules/.bin/jsii" >> $GITHUB_ENV
echo "PACMAK=${{ github.workspace }}/node_modules/.bin/jsii-pacmak" >> $GITHUB_ENV
echo "CDK_PACKAGE_JSII_PACMAK=${{ github.workspace }}/node_modules/.bin/jsii-pacmak" >> $GITHUB_ENV
echo "ROSETTA=${{ github.workspace }}/node_modules/.bin/jsii-rosetta" >> $GITHUB_ENV
echo "CDK_PACKAGE_JSII_ROSETTA=${{ github.workspace }}/node_modules/.bin/jsii-rosetta" >> $GITHUB_ENV
- name: Integration Test (build)
run: |-
npx lerna run build --concurrency=1 --stream 2>&1 > ${{ runner.temp }}/build.log
working-directory: aws-cdk
env:
# Make lots of memory available, aws-cdk-lib is __large__
NODE_OPTIONS: --max-old-space-size=8192

# In the interest of speed, only process monocdk-experiment / aws-cdk-lib from now on
- name: Integration Test (jsii-rosetta)
run: |-
npx lerna exec --scope=monocdk-experiment --scope=aws-cdk-lib --stream -- \
${ROSETTA} \
--compile \
--output ./dist/samples.tabl.json \
--directory . \
--verbose \
2>&1 > ${{ runner.temp }}/rosetta.log
working-directory: aws-cdk
- name: Integration Test (jsii-pacmak)
run: |-
npx lerna exec --scope=monocdk-experiment --scope=aws-cdk-lib --stream -- \
${PACMAK} \
--rosetta-tablet ./dist/samples.tabl.json \
--verbose \
2>&1 > ${{ runner.temp }}/pacmak.log
working-directory: aws-cdk

- name: Upload Logs
# Upload logs whether successful or failed (not using always because we don't care about cancellations)
if: success() || failure()
uses: actions/upload-artifact@v2
with:
name: integ-test-logs
path: ${{ runner.temp }}/*.log

- name: Upload Result
uses: actions/upload-artifact@v2
with:
name: integ-test-result
path: |-
${{ github.workspace }}/aws-cdk/dist/
${{ github.workspace }}/aws-cdk/**/dist/
6 changes: 0 additions & 6 deletions .mergify/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ pull_request_rules:
- status-success=Semantic Pull Request
# Docker image validation
- status-success=jsii/superchain
# Integration Tests
- status-success=Integration Test
# One test for each OS
- status-success~=^Test \(ubuntu-.*$
- status-success~=^Test \(macos-.*$
Expand Down Expand Up @@ -82,8 +80,6 @@ pull_request_rules:
- status-success=Semantic Pull Request
# Docker image validation
- status-success=jsii/superchain
# Integration Tests
- status-success=Integration Test
# One test for each OS
- status-success~=^Test \(ubuntu-.*$
- status-success~=^Test \(macos-.*$
Expand Down Expand Up @@ -133,8 +129,6 @@ pull_request_rules:
- status-success=Semantic Pull Request
# Docker image validation
- status-success=jsii/superchain
# Integration Tests
- status-success=Integration Test
# One test for each OS
- status-success~=^Test \(ubuntu-.*$
- status-success~=^Test \(macos-.*$
Expand Down

0 comments on commit 90150d5

Please sign in to comment.