Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client.authorization to v1beta1 #1426

Merged
merged 8 commits into from Mar 17, 2022
Merged

Update client.authorization to v1beta1 #1426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6078b72
Update client.authorization to v1beta1
mdsgabriel Mar 9, 2022
a4bb75b
new TEST_REGEX
mdsgabriel Mar 10, 2022
75043a3
Use v1beta1 for v1.22 or greater
mdsgabriel Mar 16, 2022
809242f
Revert change on Make file
mdsgabriel Mar 16, 2022
f0d6d52
Use v1beta1 for all k8s versions
mdsgabriel Mar 17, 2022
21e3316
Use TestDockerKubernetes121SimpleFlow again
mdsgabriel Mar 17, 2022
50091f5
USe map[string]string again
mdsgabriel Mar 17, 2022
7811aaf
Remove extra line
mdsgabriel Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/awsiamauth/config/aws-iam-authenticator-kubeconfig.yaml
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ users:
- name: {{.clusterName}}-aws
user:
exec:
apiVersion: client.authentication.k8s.io/v1alpha1
apiVersion: client.authentication.k8s.io/v1beta1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not positive you can do this. The older versions still use the older iam auth which I believe expects the v1alpha1. Worth a sort to verify tho.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V1beta1 is available since k8s 1.11

This was tested by manually creating 1.21 and 1.22 clusters and using the generated kubeconfig (cluster name-aws.kubeconfig) to get the list of pods (similar to what's done by the tests that are failing).

What other scenarios should be tested?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1beta1 apiversion has been available since k8s v1.11, but only since aws-iam-auth v0.5.4. Since 1.21 and below use aws-iam-auth versions previous to v0.5.4, we want to confirm if this change will work on them in a backward compatible manner.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the iam auth pr where it was changed

https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/386/files

Like Abhay said, eksd kube versions less than 1.22 are still using the older iam auth which was parsing it as v1alpha. I wasn't sure if they would also work if the version was v1beta1 in the config file. If you tried a 1.21 cluster with this change and it worked, then it must be ok with it. Let's just make sure we still have the 121 test in addition to the new 122 one and then we can merge and make sure tests still pass.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if doing this migration will affect our upgrade use case as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure there is an upgrade test for this.

args:
- token
- -i
Expand Down
2 changes: 1 addition & 1 deletion pkg/awsiamauth/testdata/want-aws-iam-authenticator-kubeconfig.yaml
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ users:
- name: test-cluster-aws
user:
exec:
apiVersion: client.authentication.k8s.io/v1alpha1
apiVersion: client.authentication.k8s.io/v1beta1
args:
- token
- -i
Expand Down