Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade torchserve to 0.11.0 in PT 2.1 and 2.2 graviton #3926

Merged
merged 12 commits into from
May 21, 2024

Conversation

sallyseok
Copy link
Contributor

@sallyseok sallyseok commented May 16, 2024

GitHub Issue #, if available:

Note:

  • If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.

  • All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.

Description

Tests run

PT 2.1:

  • All tests except sagemaker local and sanity test passed on 15a6eb6
    • sanity test autopatch package regression test failures are expected/ignored, because those packages aren't needed anymore, so we skip that test in the last iteration
    • sagemaker local test initially failed because of endpoint issue but it was fixed in another PR by updating requirements
  • sagemaker local and sanity test passed on c9e2d39

PT 2.2:

  • All tests except sagemaker local passed on 934127e
  • sagemaker local test passed on 0b32887

NOTE: By default, docker builds are disabled. In order to build your container, please update dlc_developer_config.toml and specify the framework to build in "build_frameworks"

  • I have run builds/tests on commit for my changes.

NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:

Expand
  • sagemaker_remote_tests = true
  • sagemaker_efa_tests = true
  • sagemaker_rc_tests = true

Additionally, please run the sagemaker local tests in at least one revision:

  • sagemaker_local_tests = true

Formatting

DLC image/dockerfile

Builds to Execute

Click the checkbox to enable a build to execute upon merge.

Note: By default, pipelines are set to "latest". Replace with major.minor framework version if you do not want "latest".

  • build_pytorch_inference_2.1_graviton
  • build_pytorch_inference_latest_graviton

Additional context

PR Checklist

Expand
  • I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron/graviton] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • If the PR changes affects SM test, I've modified dlc_developer_config.toml in my PR branch by setting sagemaker_tests = true and efa_tests = true
  • If this PR changes existing code, the change fully backward compatible with pre-existing code. (Non backward-compatible changes need special approval.)
  • (If applicable) I've documented below the DLC image/dockerfile this relates to
  • (If applicable) I've documented below the tests I've run on the DLC image
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

NEURON/GRAVITON Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting neuron_mode = true or graviton_mode = true

Benchmark Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting ec2_benchmark_tests = true or sagemaker_benchmark_tests = true

Pytest Marker Checklist

Expand
  • (If applicable) I have added the marker @pytest.mark.model("<model-type>") to the new tests which I have added, to specify the Deep Learning model that is used in the test (use "N/A" if the test doesn't use a model)
  • (If applicable) I have added the marker @pytest.mark.integration("<feature-being-tested>") to the new tests which I have added, to specify the feature that will be tested
  • (If applicable) I have added the marker @pytest.mark.multinode(<integer-num-nodes>) to the new tests which I have added, to specify the number of nodes used on a multi-node test
  • (If applicable) I have added the marker @pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">) to the new tests which I have added, if a test is specifically applicable to only one processor type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sallyseok sallyseok requested review from a team as code owners May 16, 2024 18:55
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added build Reflects file change in build folder pytorch Reflects file change in pytorch folder Size:S Determines the size of the PR labels May 16, 2024
@sallyseok sallyseok enabled auto-merge (squash) May 21, 2024 18:46
@sallyseok sallyseok merged commit 68f27de into aws:master May 21, 2024
28 checks passed
@aws-deep-learning-containers-ci

Started build_pytorch_inference_2.1_graviton, build_pytorch_inference_latest_graviton.

@sallyseok sallyseok deleted the upgrade-torchserve branch May 21, 2024 19:31
arjkesh added a commit to arjkesh/deep-learning-containers-1 that referenced this pull request May 22, 2024
commit 0fc43df
Author: Shantanu Tripathi <shantanutripathi237@gmail.com>
Date:   Wed May 22 14:22:16 2024 -0700

    [Build][Test] Re-enable AutoPatching for PT1.13 images (aws#3938)

    * Re-enable AutoPatching for PT1.13 images

    * Change to 1.13

    * Revert temp changes

commit 20fc557
Author: Adam Kozdrowicz <akozdrowicz@gmail.com>
Date:   Wed May 22 16:47:06 2024 -0400

    resolve triton import error (aws#3939)

    Resolve triton import error

commit e12ddd2
Author: Junpu Fan <junpu@amazon.com>
Date:   Wed May 22 13:23:03 2024 -0700

    fix triton version in pt2.2 inference gpu images (aws#3954)

    * fix triton version

commit 819ee20
Author: Junpu Fan <junpu@amazon.com>
Date:   Wed May 22 10:05:56 2024 -0700

    Fix triton version pt 21 inf (aws#3952)

    * Fix triton version

    * dev config

    * fix arg

    * Revert "dev config"

    This reverts commit aa4ba23.

commit 4271d84
Author: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Date:   Tue May 21 16:08:48 2024 -0700

    Fix PT 2.1 TE Test (aws#3947)

    * Fix PT 2.1 TE Test

    * test te on p5

    * skip efa

    * revert onnxruntime version

    * update onnxruntime to 1.18

    * revert onnxruntim version to be p5 compatible

    * disable onnx test

    * test te on p4

    * revert skip

commit 42ece6a
Author: Junpu Fan <junpu@amazon.com>
Date:   Tue May 21 15:03:13 2024 -0700

    Allowlist requests 2.31.0 safety finding (aws#3949)

    * allowlisting requests safety id 71064

commit 68f27de
Author: Sally Seok <49303563+sallyseok@users.noreply.github.com>
Date:   Tue May 21 11:53:34 2024 -0700

    Upgrade torchserve to 0.11.0 in PT 2.1 and 2.2 graviton (aws#3926)

    * Upgrade torchserve to 0.11.0 in PT 2.1 and 2.2 graviton

    * address CVEs

    * fix typo

    * only run 2.1 autopatch regression test

    * upgrade pyopenssl and rerun tests

    * run tests for pt2.2

    * execute SM local mode tests with updated test requirements

    * run pt2.1 sm local test; don't run package regression tests

    * revert toml

    ---------

    Co-authored-by: arjkesh <33526713+arjkesh@users.noreply.github.com>

commit 9bd5123
Author: Junpu Fan <junpu@amazon.com>
Date:   Tue May 21 10:16:07 2024 -0700

    [PT2.1][SageMaker][X86] torchserve 0.11.0 update (aws#3930)

    * torchserve 0.11.0 update
    * upgrade infernece toolkit to 2.0.23
    ---------

    Co-authored-by: arjkesh <33526713+arjkesh@users.noreply.github.com>

commit 62c6175
Author: Haotian An <33510317+Captainia@users.noreply.github.com>
Date:   Tue May 21 11:56:31 2024 -0400

    update documentation for recent releases (aws#3932)

    * update documentation for recent releases

    * remove old imgs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Reflects file change in build folder pytorch Reflects file change in pytorch folder Size:S Determines the size of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants