Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pytorch] [trcomp] Updated binaries with CVE fix for PT.12 SM Training Compiler #2478

Merged
merged 61 commits into from Dec 3, 2022

Conversation

Vatshank
Copy link
Contributor

@Vatshank Vatshank commented Dec 2, 2022

GitHub Issue #, if available:

Note: If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.

Description

Updated binaries with CVE fix for PT.12 SM Training Compiler.

CVE: https://nvd.nist.gov/vuln/detail/CVE-2022-45907
GH issue: pytorch/pytorch#88868
Fix: pytorch/pytorch#89189

Tests run

NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:

  • Revision A: sagemaker_remote_tests = "standard"
  • Revision B: sagemaker_remote_tests = "rc"
  • Revision C: sagemaker_remote_tests = "efa"

Additionally, please run the sagemaker local tests in at least one revision:

  • sagemaker_local_tests = true

DLC image/dockerfile

Additional context

Label Checklist

  • I have added the project label for this PR (<project_name> or "Improvement")

PR Checklist

  • I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron/graviton] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • If the PR changes affects SM test, I've modified dlc_developer_config.toml in my PR branch by setting sagemaker_tests = true and efa_tests = true
  • If this PR changes existing code, the change fully backward compatible with pre-existing code. (Non backward-compatible changes need special approval.)
  • (If applicable) I've documented below the DLC image/dockerfile this relates to
  • (If applicable) I've documented below the tests I've run on the DLC image
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

Pytest Marker Checklist

  • (If applicable) I have added the marker @pytest.mark.model("<model-type>") to the new tests which I have added, to specify the Deep Learning model that is used in the test (use "N/A" if the test doesn't use a model)
  • (If applicable) I have added the marker @pytest.mark.integration("<feature-being-tested>") to the new tests which I have added, to specify the feature that will be tested
  • (If applicable) I have added the marker @pytest.mark.multinode(<integer-num-nodes>) to the new tests which I have added, to specify the number of nodes used on a multi-node test
  • (If applicable) I have added the marker @pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">) to the new tests which I have added, if a test is specifically applicable to only one processor type

EIA/NEURON/GRAVITON Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting ei_mode = true, neuron_mode = true or graviton_mode = true

Benchmark Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting benchmark_mode = true

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Vatshank Vatshank requested review from a team as code owners December 2, 2022 19:27
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added build Reflects file change in build folder ec2 Reflects file change in dlc_tests/ec2 folder pytorch Reflects file change in pytorch folder sagemaker_tests sanity Reflects file change in dlc_tests/sanity folder Size:S Determines the size of the PR test Reflects file change in test folder labels Dec 2, 2022
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added the Size:XS Determines the size of the PR label Dec 2, 2022
harishneit
harishneit previously approved these changes Dec 2, 2022
Copy link
Contributor

@ohadkatz ohadkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@tejaschumbalkar tejaschumbalkar merged commit cab3451 into master Dec 3, 2022
@saimidu saimidu deleted the pt1.12_trcomp branch November 30, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Reflects file change in build folder ec2 Reflects file change in dlc_tests/ec2 folder pytorch Reflects file change in pytorch folder sagemaker_tests sanity Reflects file change in dlc_tests/sanity folder Size:S Determines the size of the PR Size:XS Determines the size of the PR test Reflects file change in test folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants