New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pytorch] [trcomp] Updated binaries with CVE fix for PT.12 SM Training Compiler #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harish Tummalacherla <hartum@amazon.com>
aws-deep-learning-containers-ci
bot
added
build
Reflects file change in build folder
ec2
Reflects file change in dlc_tests/ec2 folder
pytorch
Reflects file change in pytorch folder
sagemaker_tests
sanity
Reflects file change in dlc_tests/sanity folder
Size:S
Determines the size of the PR
test
Reflects file change in test folder
labels
Dec 2, 2022
aws-deep-learning-containers-ci
bot
added
the
Size:XS
Determines the size of the PR
label
Dec 2, 2022
harishneit
previously approved these changes
Dec 2, 2022
ohadkatz
approved these changes
Dec 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
harishneit
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Reflects file change in build folder
ec2
Reflects file change in dlc_tests/ec2 folder
pytorch
Reflects file change in pytorch folder
sagemaker_tests
sanity
Reflects file change in dlc_tests/sanity folder
Size:S
Determines the size of the PR
Size:XS
Determines the size of the PR
test
Reflects file change in test folder
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue #, if available:
Note: If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.
Description
Updated binaries with CVE fix for PT.12 SM Training Compiler.
CVE: https://nvd.nist.gov/vuln/detail/CVE-2022-45907
GH issue: pytorch/pytorch#88868
Fix: pytorch/pytorch#89189
Tests run
NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:
sagemaker_remote_tests = "standard"
sagemaker_remote_tests = "rc"
sagemaker_remote_tests = "efa"
Additionally, please run the sagemaker local tests in at least one revision:
sagemaker_local_tests = true
DLC image/dockerfile
Additional context
Label Checklist
PR Checklist
Pytest Marker Checklist
@pytest.mark.model("<model-type>")
to the new tests which I have added, to specify the Deep Learning model that is used in the test (use"N/A"
if the test doesn't use a model)@pytest.mark.integration("<feature-being-tested>")
to the new tests which I have added, to specify the feature that will be tested@pytest.mark.multinode(<integer-num-nodes>)
to the new tests which I have added, to specify the number of nodes used on a multi-node test@pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">)
to the new tests which I have added, if a test is specifically applicable to only one processor typeEIA/NEURON/GRAVITON Testing Checklist
dlc_developer_config.toml
in my PR branch by settingei_mode = true
,neuron_mode = true
orgraviton_mode = true
Benchmark Testing Checklist
dlc_developer_config.toml
in my PR branch by settingbenchmark_mode = true
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.