Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup delay addition for code scan issues. #4436

Merged
merged 4 commits into from May 8, 2024

Conversation

ashishrp-aws
Copy link
Contributor

…pups during mouse hovers.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Problem: Due to introduction of pro-active scans, users are seeing code scan issues in their code and are seeing issue pop ups too frequently during mouse hovers which are causing user pain.

Solution: Quick solution was to setup a delay for popup to appear, so popups would not show up during random mouse hovers but intentionally when mouse pointer is placed on issue text for delay time(1.5 seconds). The delay time of 1.5 seconds was set after local testing but could alter user feedback.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishrp-aws ashishrp-aws requested a review from a team as a code owner May 6, 2024 23:51
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

@ashishrp-aws ashishrp-aws merged commit df6bfa7 into aws:main May 8, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants