Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not serialize empty lists in ec2 protocol #3017

Merged
merged 4 commits into from
May 2, 2024
Merged

Conversation

jterapin
Copy link
Contributor

@jterapin jterapin commented May 2, 2024

Smithy to release updated test case to match this fix: smithy-lang/smithy#2269


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md

Thank you for your contribution!

Copy link

github-actions bot commented May 2, 2024

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md

Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - looks good!

Needs a changelog but otherwise good.

@jterapin jterapin marked this pull request as ready for review May 2, 2024 21:18
@jterapin jterapin merged commit ceed0ac into version-3 May 2, 2024
28 checks passed
@jterapin jterapin deleted the fix_ec2_empty_lists branch May 2, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants