Do not include sse configuration of source object in that of the destination object #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying objects using `Aws::S3::Object.copy_to(..., multipart_copy: true)`, the `ObjectMultipartCopier` was inferring the metadata of the destination object from that of the source object. This is fine for `content_type`, `content_length`, etc.; however, the `ssekms_key_id` and `server_side_encryption` attributes were also copied. This causes the destination object to use the kms key of the source, which is not usually appropriate if the destination bucket has a different default encryption than the source. This is especially true when copying from one account to the other.
alextwoods
reviewed
May 1, 2024
|
Sure thing! |
|
@alextwoods added |
mullermp
approved these changes
May 4, 2024
| @@ -257,8 +257,7 @@ module S3 | |||
| allow(client).to receive(:head_object).with({ | |||
| bucket: 'source-bucket', | |||
| key: 'source key' | |||
| }).and_return(Types::HeadObjectOutput.new( | |||
| content_length: size, content_type: 'ContentType')) | |||
| }).and_return(Types::HeadObjectOutput.new(content_length: size, content_type: 'ContentType')) | |||
There was a problem hiding this comment.
Yuck.. I'm not sure why this is here. Do you mind changing all of these to stub_data?
|
@mullermp gladly |
mullermp
approved these changes
May 5, 2024
|
Sure thing! Thanks for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying objects using
Aws::S3::Object.copy_to(..., multipart_copy: true), theObjectMultipartCopierwas inferring the metadata of the destination object from that of the source object. This is fine forcontent_type,content_length, etc.; however, thessekms_key_idandserver_side_encryptionattributes were also copied. This causes the destination object to use the kms key of the source, which is not usually appropriate if the destination bucket has a different default encryption than the source. This is especially true when copying from one account to the other. This change is in line with the behavior ofAws::S3::Client.copy_objectwhich does not copy the source object encryption.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.