Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBS signatures for customizations of s3 #3013

Merged
merged 5 commits into from Apr 30, 2024

Conversation

ksss
Copy link
Contributor

@ksss ksss commented Apr 27, 2024

I wrote the RBS for the customizations code.

When performing type checks, emphasis is placed on correcting undefined method errors, and the types of arguments are not specified in detail.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md

Thank you for your contribution!

Copy link
Contributor

@mullermp mullermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these! At a glance these look ok. I can take a deeper look tomorrow night / Monday and get it merged then. Approving CI for you now.

gems/aws-sdk-s3/sig/customizations/object.rbs Outdated Show resolved Hide resolved
Copy link
Contributor

@mullermp mullermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! If you can address that one change (or provide input otherwise), I'd be happy to merge this.

@ksss
Copy link
Contributor Author

ksss commented Apr 30, 2024

Thank you for reviewing. I resolved!

Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

@mullermp mullermp merged commit d834955 into aws:version-3 Apr 30, 2024
22 of 27 checks passed
@ksss ksss deleted the aws-sdk-s3-customizations-rbs branch April 30, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants