Event Stream fixes for qbusiness #3011
Conversation
|
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md |
|
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md |
|
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md |
|
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md |
|
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md |
…n renders; move invocation id to be default
build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/plugin_list.rb
Show resolved
Hide resolved
alextwoods
changed the title
…to q_event_stream_fixes
| @@ -48,7 +48,7 @@ | |||
|
|
|||
| sent_event = same_client.send_events[0] | |||
| expect(sent_event.headers[":event-type"].value).to eq('BazResult') | |||
| expect(sent_event.payload.read).to eq("{\"Details\":[\"baz\"]}") | |||
| expect(sent_event.payload.read).to eq("{\"Result\":{\"Details\":[\"baz\"]}}") | |||
There was a problem hiding this comment.
This change is the change in behavior for implicit payload member. This is modeled as:
"BazEvent": {
"type": "structure",
"members": {
"Result": {
"shape": "Result"
}
},
"event": true
},
We were previously treating result as the implicit payload (even though it was a structure and not a string/blob...)
| @@ -25,7 +25,6 @@ | |||
| end | |||
|
|
|||
| it 'does not modify given idempotency tokens' do | |||
| expect(SecureRandom).not_to receive(:uuid) | |||
There was a problem hiding this comment.
invocation id now gets a random id, but we test below that the client_token is preserved, so this can be removed without weakning the tst.
|
|
||
| # Minimum `aws-sdk-core` version for new S3 gem builds | ||
| MINIMUM_CORE_VERSION_S3 = "3.192.0" | ||
| MINIMUM_CORE_VERSION_S3 = "3.192.2" |
| @client_constructor = ClientConstructor.new( | ||
| options.merge( | ||
| plugins: @plugins, | ||
| codegenerated_plugins: @codegenerated_plugins)) | ||
| codegenerated_plugins: @codegenerated_plugins, | ||
| default_plugins: @default_plugins)) |
There was a problem hiding this comment.
We should have this for regular class too. There are missign docs.
| @@ -6,7 +6,6 @@ class EventEmitter | |||
| def initialize | |||
| @listeners = {} | |||
| @validate_event = true | |||
| @status = :sleep | |||
alextwoods
changed the title
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.mdfile (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeatureorIssuein the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!