Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPCv2 and cbor support #3006

Open
wants to merge 59 commits into
base: version-3
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
c4aa004
Initial CBOR work
mullermp Apr 11, 2024
c389458
Remove client spec
mullermp Apr 11, 2024
7157890
Test runner for decode success
mullermp Apr 11, 2024
86b8de0
Add error test runner
mullermp Apr 11, 2024
0b24ecc
Major CBOR refactoring, all tests pass
alextwoods Apr 11, 2024
870d738
Fix error decoder specs
alextwoods Apr 11, 2024
3eac02a
Remove decoder spec, use utc in encoder spec
alextwoods Apr 11, 2024
bf23dbf
Fix time test - use utc
alextwoods Apr 11, 2024
05c4722
Rubocop/style cleanups
alextwoods Apr 12, 2024
029e8f0
Rename spec
alextwoods Apr 12, 2024
885c880
Merge branch 'version-3' into cbor
mullermp Apr 15, 2024
b5d2aab
WIP: protocol tests
mullermp Apr 15, 2024
7f5ff9f
Fix some parts of test runner for rpcv2 + add Time parsing to decoder…
alextwoods Apr 15, 2024
14f2bfa
Add other engine support and untangle error handlers across all proto…
mullermp Apr 15, 2024
5070c61
More refactors and test passing
mullermp Apr 16, 2024
f67973e
More test fixes
mullermp Apr 16, 2024
0b52fa1
Protocol tests pass
mullermp Apr 16, 2024
702d9de
Remove cbor gem
mullermp Apr 16, 2024
daff795
More refactors around cbor half and handlers
mullermp Apr 16, 2024
345024b
Flatten cbor and bring back half
mullermp Apr 16, 2024
5f8c337
Flatten json and xml engines
mullermp Apr 16, 2024
46988ce
Per engine protocol tests
mullermp Apr 16, 2024
6b998e1
Merge branch 'version-3' into cbor
mullermp Apr 16, 2024
824188f
Fix some other spec files
mullermp Apr 16, 2024
ee3c477
Update assert to handle hash values when nil
jterapin Apr 16, 2024
531d2d9
Update test runner to include test ids
jterapin Apr 16, 2024
2d01fae
Merge branch 'version-3' into cbor
mullermp Apr 19, 2024
185f88d
PR feedback
mullermp Apr 19, 2024
e15456f
Fix jruby tests
mullermp Apr 19, 2024
06289c6
Support protocols generation resolution
mullermp Apr 19, 2024
f6185e4
Fix test
mullermp Apr 19, 2024
5d4d732
Fix other test
mullermp Apr 19, 2024
6edddb3
Fix failing tests again
mullermp Apr 19, 2024
bdf3fa6
Merge branch 'version-3' into cbor
mullermp Apr 19, 2024
5e08ccb
Merge branch 'version-3' into cbor
mullermp Apr 21, 2024
a8856e6
Fix json extras tests
mullermp Apr 21, 2024
cec94b1
Fix generating event in event stream with no members
mullermp Apr 21, 2024
2bc4072
Revert "Fix generating event in event stream with no members"
mullermp Apr 21, 2024
cc02a70
Update decode tests
mullermp Apr 29, 2024
3c9166d
Merge branch 'version-3' into cbor
mullermp Apr 29, 2024
e3bf737
Update minimum version
mullermp Apr 29, 2024
0d8f8b0
Try new changelog action
mullermp Apr 29, 2024
a6ae549
Merge branch 'version-3' into cbor
mullermp Apr 30, 2024
85b65f4
Malformed request handling - broken protocol tests
mullermp Apr 30, 2024
3e8d7d2
New protocol tests
mullermp Apr 30, 2024
eca72ac
Update cbor decode tests from upstream
alextwoods May 20, 2024
01ad272
Add new float16 protocol tests
alextwoods May 20, 2024
3bd66e3
Merge branch 'version-3' into cbor
mullermp May 22, 2024
0b46348
Minimum core version bump
mullermp May 22, 2024
ec3615e
Change format of ignore list to not be per-engine keys
mullermp May 22, 2024
570b4e0
PR feedback [ci skip]
mullermp May 22, 2024
22a5d2a
Merge branch 'version-3' into cbor
mullermp May 22, 2024
37def58
Event stream support and refactor protocols
mullermp May 22, 2024
85c5cd2
Fix tests
mullermp May 22, 2024
25f6e54
Handle event stream responses correctly
mullermp May 27, 2024
d2a2968
force encoding of blobs to binary
alextwoods May 22, 2024
396d50d
Merge branch 'cbor' of github.com:aws/aws-sdk-ruby into cbor
alextwoods May 30, 2024
db5fbba
Bubble up force encoding binary
mullermp May 31, 2024
0ab6400
Revert "Bubble up force encoding binary"
mullermp May 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,15 @@ gem 'aws-crt' if ENV['CRT']
gem 'http-2'
gem 'jmespath'

# json and xml parsers
# protocol parsers
mullermp marked this conversation as resolved.
Show resolved Hide resolved
gem 'json'
gem 'nokogiri', '>= 1.6.8.1'
gem 'oga'
gem 'rexml'

# These json and xml parsers do not have java gems
# These protocol parsers do not have java gems
unless defined?(JRUBY_VERSION)
gem 'cbor'
gem 'libxml-ruby'
gem 'oj'
gem 'ox'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ def protocol_plugins(protocol)
'rest-xml' => { 'Aws::Plugins::Protocols::RestXml' => "#{core_plugins}/protocols/rest_xml.rb" },
'query' => { 'Aws::Plugins::Protocols::Query' => "#{core_plugins}/protocols/query.rb" },
'ec2' => { 'Aws::Plugins::Protocols::EC2' => "#{core_plugins}/protocols/ec2.rb" },
'smithy-rpc-v2-cbor' => { 'Aws::Plugins::Protocols::RpcV2' => "#{core_plugins}/protocols/rpc_v2.rb" },
'api-gateway' => {
'Aws::Plugins::Protocols::ApiGateway' => "#{core_plugins}/protocols/api_gateway.rb",
'Aws::Plugins::ApiKey' => "#{core_plugins}/api_key.rb",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,21 +1,4 @@
{
"ec2" :
{
"input" : [],
"output" : []
},
"json" : {
"input" : [],
"output" : []
},
"json_1_0" : {
"input" : [],
"output" : []
},
"query" : {
"input" : [],
"output" : []
},
"rest-json" : {
"input" : [],
"output" : [
Expand All @@ -27,9 +10,5 @@
"output" : [
{"SimpleScalarPropertiesComplexEscapes": "OxEngine does not handle all escape cases but other engines supports it"}
]
},
"api-gateway" : {
"input" : [],
"output" : []
}
}