Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump patch version of Guzzle for PHP 7.3 compatibility #1647

Merged
merged 1 commit into from Oct 19, 2018
Merged

Bump patch version of Guzzle for PHP 7.3 compatibility #1647

merged 1 commit into from Oct 19, 2018

Conversation

carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Oct 15, 2018 •
edited

@carusogabriel carusogabriel mentioned this pull request Oct 15, 2018
Closed
@codecov-io
Copy link

codecov-io commented Oct 15, 2018 •
edited

Codecov Report

Merging #1647 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1647   +/-   ##
=========================================
  Coverage     93.92%   93.92%           
  Complexity     2832     2832           
=========================================
  Files           171      171           
  Lines          7572     7572           
=========================================
  Hits           7112     7112           
  Misses          460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c8b65f...556f241. Read the comment docs.

howardlopez
howardlopez suggested changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@howardlopez howardlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small note to leave nightly in.

.travis.yml Outdated
- hhvm
- nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave nightly in here. It may be redundant with 7.3 for some period of time, but going forward we'll always want to test against the latest build.

.travis.yml Outdated
- php: hhvm
- php: nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, let's leave nightly in here.

@howardlopez howardlopez merged commit 346a107 into aws:master Oct 19, 2018
@carusogabriel carusogabriel deleted the patch-1 branch October 20, 2018 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardlopez howardlopez howardlopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carusogabriel @codecov-io @howardlopez