Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(util): use custom MD5 checksum instead of native for FIPS environments #4332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukiano
Copy link

@lukiano lukiano commented Feb 2, 2023

Logic copied from aws-sdk-js-v3

Let me know your thoughts on this. the browserMd5 file also has a similar logic.

The checksum is used for integrity checks, at least in SQS and S3. Because this isn't about ensuring the data hasn't been tampered with, it should be fine in a FIPS environment. Besides, the V3 of the aws-sdk does the same.

Checklist
  • npm run test passes
  • changelog is added, npm run add-change

@nguyenpc
Copy link

Should this be reviewed and merged? The S3 SSE-C approach won't work in FIPS mode without this.

@kuhe
Copy link
Contributor

kuhe commented Sep 29, 2023

For now, please overwrite the AWS.util function in question at runtime with your custom MD5 implementation if you need it in your environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants