Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sync I/O from TokenFileWebIdentityCredentials #3986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gabegorelick
Copy link

See #3802

Checklist
  • npm run test passes
  • changelog is added, npm run add-change

@gabegorelick gabegorelick requested a review from a team as a code owner December 10, 2021 22:35
@github-actions
Copy link

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Dec 11, 2022
@gabegorelick
Copy link
Author

Still an issue:

var oidcToken = fs.readFileSync(params.envTokenFile, {encoding: 'ascii'});

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant