Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: managed upload resolves config repeatedly #3700

Merged
merged 2 commits into from
Apr 8, 2021
Merged

fix: managed upload resolves config repeatedly #3700

merged 2 commits into from
Apr 8, 2021

Commits on Apr 8, 2021

  1. fix: managed upload not to resolve config repeatedly 

    Previously the managed upload creates new S3 clients with the
constructor parameters of the S3 client used to create the managed
upload. That results in that the newly created S3 client needs to
resolve every config, including the credentials over and over
again.

This issue was introduced by aws#3109 to make sure the internal S3
client inside of managed upload has the same constructor parameters
of the S3 client used to create the managed upload. So that the
logic relies on the constructor parameters like access point
and endpoint discovery works properly.

This change supply the resolved client config to create the
managed upload internal S3 client so configs don't need to be
resolved again, like credentials. Meanwhile, we explicitly set
the constructor parameter to be the same as that of S3 client
used to create the managed upload.
    @AllanZhengYP
    AllanZhengYP committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    6e3f8cc View commit details
    Browse the repository at this point in the history

  2. address feedbacks 

    Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
    @AllanZhengYP @trivikr
    AllanZhengYP and trivikr committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    ec2df2c View commit details
    Browse the repository at this point in the history