Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(credential-providers): source accountId from credential providers #6019

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

siddsriv
Copy link
Contributor

@siddsriv siddsriv commented Apr 24, 2024

Issue

Internal JS-4633
Part 1

Description

Sources accountId from credential providers.

PR to update AwsCredentialIdentity interface: smithy-lang/smithy-typescript#1240

Testing

To-Do:

  • merge AwsCredentialIdentity interface PR above
  • Run (updated) unit tests following above merge for all the credential providers that were modified.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv siddsriv requested a review from a team as a code owner April 24, 2024 02:24
@trivikr trivikr marked this pull request as draft April 24, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant