fix(client-s3-control): add prefix dedupe middleware #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
fix/host-prefix
branch
from
bb3c464
to
b53550b
Compare
kuhe
force-pushed
the
fix/host-prefix
branch
from
b53550b
to
d42df1b
Compare
trivikr
reviewed
Dec 14, 2022
packages/middleware-sdk-s3-control/src/host-prefix-deduplication/deduplicateHostPrefix.spec.ts
Outdated
Show resolved
Hide resolved
kuhe
force-pushed
the
fix/host-prefix
branch
from
cebe539
to
7dff8ee
Compare
trivikr
approved these changes
Dec 14, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revealed by #4284
deduplicates identical position 1 and position 2 host prefixes in s3-control.