Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-client-retry-test): correct retry delay assertion #4274

Merged
merged 1 commit into from Dec 12, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Dec 12, 2022

confirmed with original author:

The current and new implementation can yield delays of less than the base of 100.
new implementation:

const computeNextBackoffDelay = (attempts: number) => {
return Math.floor(Math.min(MAXIMUM_RETRY_DELAY, Math.random() * 2 ** attempts * delayBase));
};

existing:

Math.floor(Math.min(MAXIMUM_RETRY_DELAY, Math.random() * 2 ** attempts * delayBase));

@kuhe kuhe requested a review from a team as a code owner December 12, 2022 20:51
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants