feat(endpoint): add wire protocol filtering option to copy models script #4068
+61
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
feat/endpoints-2.0
branch
from
228a322 to
5328d59
Compare
kuhe
commented
Oct 20, 2022
| try { | ||
| const fileContent = (await fsPromises.readFile(smithyModelsFile)).toString(); | ||
| const model = require(absolutePath); |
There was a problem hiding this comment.
switching to require since this is a JSON file
| await spawnProcess(join(__dirname, "..", "..", "node_modules", ".bin", "prettier"), [ | ||
| "--write", | ||
| `${OUTPUT_DIR}/*.json`, | ||
| ]); |
There was a problem hiding this comment.
removing prettier step to save time. JSON.stringify(, null, 2) is good enough.
kuhe
commented
Oct 20, 2022
| try { | ||
| const fileContent = (await fsPromises.readFile(smithyModelsFile)).toString(); | ||
| const model = require(absolutePath); | ||
| const sdkId = getSdkId(model).toLowerCase().replace(/\s/g, "-"); |
There was a problem hiding this comment.
confirmed this is the same set of filenames as before and does not create any new files
test: yarn copy-models -m ...
trivikr
reviewed
Oct 20, 2022
trivikr
approved these changes
Oct 20, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
internal JS-3670
Description
yarn copy-modelsyarn copy-models -m ../_models -p restXml