fix(codegen): fix set deserialization in SSDKs #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using JavaScript's Set to detect duplicate items does not work for non-primitive types. There's a function in server-common to detect duplicates of any type, and detecting them in server deserialization is much more important than client deserialization, so the check has been moved to server-only.
|
Note that this won't pass CI until smithy-lang/smithy-typescript#511 is merged |
gosar
approved these changes
Feb 17, 2022
trivikr
approved these changes
Feb 18, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using JavaScript's Set to detect duplicate items does not work for
non-primitive types. There's a function in server-common to detect duplicates
of any type, and detecting them in server deserialization is much more
important than client deserialization, so the check has been moved to
server-only.
Testing
New protocol tests in smithy-lang/smithy#1094
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.