Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): generate heap dump on OutOfMemory error #3317

Merged
merged 1 commit into from Feb 15, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 15, 2022

Issue

The OutOfMemory error appears even after we increased maximum size of memory allocation pool to 4g in #3253

Description

Temporarily disable manual increase of maximum memory size of memory allocation pool in Java, and generate heap dump on OutOfMemory.

Testing

The command yarn generate-clients is successful in the workspace hosted on c5.9xlarge

Additional context

Java docs: https://docs.oracle.com/javase/7/docs/webnotes/tsg/TSG-VM/html/clopts.html


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner February 15, 2022 22:52
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp approval. I will defer to @adamthom-amzn

@trivikr trivikr merged commit cc2e4a6 into aws:main Feb 15, 2022
@trivikr trivikr deleted the enable-heap-dump-on-out-of-memory branch February 15, 2022 22:59
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants