Skip to content

chore(codegen): populate identifiers for endpoint discovery #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 2, 2021

Issue

Follow-up to #2395

Description

Populates identifiers for endpoint discovery by reading ClientEndpointDiscoveryIdTrait

Testing

N/A as ClientEndpointDiscoveryIdTrait is not populated in any models.
Verified that generated clients are not updated.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@5e3db00). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2539   +/-   ##
=======================================
  Coverage        ?   60.24%           
=======================================
  Files           ?      513           
  Lines           ?    27359           
  Branches        ?     6421           
=======================================
  Hits            ?    16482           
  Misses          ?    10877           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e3db00...6727b92. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 6727b92
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 4d085af into aws:main Jul 2, 2021
@trivikr trivikr deleted the endpoint-discovery-identifiers branch July 2, 2021 17:53
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants