Skip to content

chore(codegen): pull dependency versions from package.json #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

adamthom-amzn
Copy link
Contributor

@adamthom-amzn adamthom-amzn commented Jun 11, 2021

Description

When the versions in package.json get out of sync across the generators, we start to get weird build failures in our other test packages. This just pulls the version of the SDK dependencies from each SDK package's package.json

Testing

I locally generated a client and service with this change and both worked.

Additional context

This is meant to replace the need for semi-regular updates like 597e689


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@d966629). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head fdd21e5 differs from pull request most recent head e5ac1a2. Consider uploading reports for the commit e5ac1a2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2481   +/-   ##
=======================================
  Coverage        ?   59.54%           
=======================================
  Files           ?      494           
  Lines           ?    26394           
  Branches        ?     6269           
=======================================
  Hits            ?    15715           
  Misses          ?    10679           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d966629...e5ac1a2. Read the comment docs.

Copy link
Contributor

@gosar gosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the couple of packages in that PR that didn’t have 3.15.0 earlier, @aws-sdk/xml-builder, and @aws-sdk/middleware-endpoint-discovery , seem to have 3.18.0 too now. maybe they can also be changed to use LIVE

@adamthom-amzn
Copy link
Contributor Author

the couple of packages in that PR that didn’t have 3.15.0 earlier, @aws-sdk/xml-builder, and @aws-sdk/middleware-endpoint-discovery , seem to have 3.18.0 too now. maybe they can also be changed to use LIVE

I'm going to solicit the input of people who know why those versions were so widely divergent previously before I make any changes to it.

@trivikr trivikr changed the title chore(codegen) pull dependency versions from parent package.json chore(codegen): pull dependency versions from parent package.json Jun 17, 2021
@adamthom-amzn adamthom-amzn changed the title chore(codegen): pull dependency versions from parent package.json chore(codegen): pull dependency versions from package.jsons Jun 17, 2021
@adamthom-amzn adamthom-amzn requested review from gosar and trivikr June 17, 2021 18:10

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@trivikr trivikr changed the title chore(codegen): pull dependency versions from package.jsons chore(codegen): pull dependency versions from package.json Jun 24, 2021
@trivikr trivikr merged commit 9144509 into aws:main Jun 24, 2021
@github-actions
Copy link

github-actions bot commented Jul 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants