-
Notifications
You must be signed in to change notification settings - Fork 619
chore(codegen): pull dependency versions from package.json #2481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2481 +/- ##
=======================================
Coverage ? 59.54%
=======================================
Files ? 494
Lines ? 26394
Branches ? 6269
=======================================
Hits ? 15715
Misses ? 10679
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the couple of packages in that PR that didn’t have 3.15.0 earlier, @aws-sdk/xml-builder, and @aws-sdk/middleware-endpoint-discovery , seem to have 3.18.0 too now. maybe they can also be changed to use LIVE
I'm going to solicit the input of people who know why those versions were so widely divergent previously before I make any changes to it. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Description
When the versions in package.json get out of sync across the generators, we start to get weird build failures in our other test packages. This just pulls the version of the SDK dependencies from each SDK package's package.json
Testing
I locally generated a client and service with this change and both worked.
Additional context
This is meant to replace the need for semi-regular updates like 597e689
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.