Skip to content

docs(upgrading): add waiters and credentials upgrading guide #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented May 20, 2021

Resolves: #2405

Description

add waiters and credentials(with all the v2 credentials the their equivalents in v3) to upgrading guide


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@10db5ac). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2410   +/-   ##
=======================================
  Coverage        ?   59.08%           
=======================================
  Files           ?      490           
  Lines           ?    26204           
  Branches        ?     6224           
=======================================
  Hits            ?    15482           
  Misses          ?    10722           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10db5ac...d7509ab. Read the comment docs.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review May 24, 2021 17:30
@alexforsyth
Copy link
Contributor

Reference from readme and reference in dev guide

@alexforsyth
Copy link
Contributor

API reference?

@AllanZhengYP
Copy link
Contributor Author

@alexforsyth This file is already mentioned in the README, hence the API reference. I will add it to dev guide too.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! +1

@AllanZhengYP AllanZhengYP merged commit b9c1904 into aws:main Jun 2, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to configure timeouts in v3?
3 participants