fix for #2274/ #2255 EndpointToRegion-> ip adress & port without sche… #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@debora-ito I've just seen there is an opened PR for the same issue. Sorry for duplication. If it is ok, I am going to leave it here for a review anyway. This solution looks for me a bit leaner. Thank you in advance.🙂 |
|
Hi @TommyWind Thank you for your pull request! After careful reviewing the code, we have decided to merge #2256 instead because there might be some other edge cases that cause |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me in endpoint
*Issue #2274/ #2255
*Description of changes: fixes EndpointToRegion#guessRegionNameForEndpoint for Endpoint String without Schema. Example added to tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.