Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix comment to method call #5212

Merged
merged 3 commits into from May 10, 2024

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented May 10, 2024

Insert the comment to before the method call to make it easier and more
apparent what the comment is referring to. Using Space to insert
comments here is more idiomatic, and gives us more control of where the
comments appear and what they look like.

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir requested a review from a team as a code owner May 10, 2024 00:02
@dagnir dagnir force-pushed the dongie/migration-tool/comments branch from 6ae8ecf to 67f5ead Compare May 10, 2024 18:23
Insert the comment to before the method call to make it easier and more
apparent what the comment is referring to. Using Space to insert
comments here is more idiomatic, and gives us more control of where the
comments appear and what they look like.
@dagnir dagnir force-pushed the dongie/migration-tool/comments branch from 67f5ead to 3fb6b46 Compare May 10, 2024 18:26
@dagnir dagnir changed the title Set comments on tree prefix Prefix comment to method call May 10, 2024
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
40.2% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@dagnir dagnir merged commit 8f14af3 into feature/master/migration-tool May 10, 2024
16 of 17 checks passed
@dagnir dagnir deleted the dongie/migration-tool/comments branch May 10, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants