Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP settings mapping part 1: remove HTTP settings from client configu… #5211

Merged
merged 2 commits into from May 10, 2024

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented May 9, 2024

…ration

Motivation and Context

HTTP setting mapping part 1: remove HTTP settings from client configuration.

new ClientConfiguration().withMaxConnections(1000);

becomes

ClientOverrideConfiguration.builder().build();

Modifications

Created HttpSettingsToHttpClient that is supposed to do the following.

  1. remove HTTP settings from client configuration [In this PR]
  2. create ApacheHttpClientBuilder and configure the settings [Future PR]
  3. configure httpClientBuilder on the SDK client [Future PR]

This PR implements the first part.

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner May 9, 2024 23:34
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
40.7% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@zoewangg zoewangg merged commit 9408e75 into feature/master/migration-tool May 10, 2024
16 of 17 checks passed
@zoewangg zoewangg deleted the zoewang/httpConfig-part1 branch May 10, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants