Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NumberToDuraion recipe to handle variable #5208

Merged

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented May 9, 2024

Motivation and Context

Fix NumberToDuraion recipe to handle variable, currently, the following exception will be thrown if the input is not a literal.

Caused by: java.lang.IllegalArgumentException: Template parameter 0 cannot be used in an untyped template substitution. Instead of "#{}", indicate the template parameter's type with "#{any(int)}".

@zoewangg zoewangg requested a review from a team as a code owner May 9, 2024 15:42
@zoewangg zoewangg force-pushed the zoewang/fixNumberToDuration branch from c0279b2 to 3178050 Compare May 9, 2024 22:28
Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
41.4% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@zoewangg zoewangg merged commit 55004c5 into feature/master/migration-tool May 9, 2024
16 of 17 checks passed
@zoewangg zoewangg deleted the zoewang/fixNumberToDuration branch May 9, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants