Catch UncheckedIOException and throw as IOException #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
millems
approved these changes
May 8, 2024
Comment on lines
243
to
249
| return s -> { | ||
| try { | ||
| s.read(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| }; |
There was a problem hiding this comment.
This could be simplified to return FunctionUtils.invokeSafely(s::read);
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
IOExceptions such as closed socket are wrapped as
UncheckedIOExceptionby theStoringSubscriber. They are then wrapped asSdkClientExceptionin theCombinedResponseHandler, making them non-retryable. They should be retryable and not wrapped.This can occur when the socket is closed by the server during a
GetObjectcall.Modifications
Catch
UncheckedIOExceptioninInputStreamSubscriber.read()and throw asIOException. This will now be retried sinceCombinedResponseHandlerthrowsIOExceptionas is and does not wrap asSdkClientException.Testing
added unit tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License