Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package name for migration tool and update dependencies #5200

Merged

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented May 8, 2024

Motivation and Context

  • Change package name for migration tool AwsJavaSdk-MigrationTool -> AwsJavaSdk-Tooling-MigrationTool to not cause potential naming conflicts in the future.
  • Update dependencies
  • Exclude migration-tool-tests from javadoc and deployment

@zoewangg zoewangg requested a review from a team as a code owner May 8, 2024 18:12
.brazil.json Outdated
@@ -102,7 +102,8 @@
"test-utils": { "skipImport": true },
"tests-coverage-reporting": { "skipImport": true },
"third-party": { "skipImport": true },
"third-party-slf4j-api": { "skipImport": true }
"third-party-slf4j-api": { "skipImport": true },
"migration-tool-tests": {"migration-tool-tests": true}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be "skipImport": true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
41.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@zoewangg zoewangg merged commit 55da9ba into feature/master/migration-tool May 8, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants