Adds list of string to endpoint/auth scheme parameters and support for JmesPath-defined operation context parameters #5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd Auth schemes params based on end-point-rule-set.json. (#5122) * feat(StringArrayEndpointParams) Codegen String Array Enpoint params and Auth schemes params based on end-point-rule-set.json. * addressed review comments v1
…s-sdk-java-v2 into feature/StringArrayEndpointParams
…ts, until all SDKs add support for string array. (#5137) * new(StringArrayEndpointParams) Customization of String Array Enpoint params because S3 Access grants will not update the models until all sdks support stringarray endpoint params * addressed review comments v1
…ms defined for a Operation. (#5146) * new(StringArrayEndpointParams) Codegeneration of OperationContextParams defined for a Operation * addressed review comments v1
…ams and adding customizations for S3
…text params and adding customizations for S3" This reverts commit 0afffa3.
* Extracting existing JMESPath runtime to a separate class that can be used by waiters and other components * Deleted temp file * Changing name from JPath to JmesPath
…ams and adding customizations for S3 (#5159) new(StringArrayEndpointParams) Customization of Operation Context params and adding customizations for S3
* Converts endpoint param list of string to list of value, so that the rules engine can handle it * Moved to identifier token
* Generates JmesPath expressions for operation context parameters * Added test cases for runtime value functions * Updating exceptions
* Supporting wildcard and keys fn in JmesPathRuntime * Removing try catch, fixes test bug and filters null elements
cenedhryn
changed the title
cenedhryn
commented
May 13, 2024
| "stringarray".equals(parameterModel.getType().toLowerCase(Locale.US)); | ||
| } | ||
|
|
||
| //TODO (string-array-params): resolve this logical test before finalizing coding |
There was a problem hiding this comment.
Adding handling this TODO to the fast-follow cleanup task.
|
dagnir
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Endpoint and auth scheme parameters are currently limited to String and Boolean types, which does not support use cases where endpoint resolution or authentication logic needs to evaluate lists of values. With this change, the SDK
customization.configfileLimitation:
customization.configfile at this time. Eventually, there will be service model supportModifications
List of string as endpoint param type
stringarrayto the endpoint/auth scheme paramsOperation Context Params
customization.configwhich is added to the intermediate model when the code generator interprets the service model.JmesPath
Waiters, to be aJmesPathRuntimeavailable to all of the SDK componentskeysandwildcardto the JmesPath expression parser, code generator and runtimeS3
DeleteObjectKeysas a new OperationContextParam (and EndpointParam) incustomization.config. The JmesPath expression isDelete.Objects[*].Key, and will return all values of theObjectIdentifierfieldkeyin a request object.Testing
Unit and functional testing. See especially
DeleteObjectKeysOperationContextParam)Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License