Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(StringArrayEndpointParams) Customization of Operation Context params and adding customizations for S3 #5159

Conversation

joviegas
Copy link
Contributor

@joviegas joviegas commented Apr 26, 2024

Motivation and Context

  • For S3 the Operation context will be added through Customization.
  • This is done because other SDKs have not been updated for the Model changes for operationContextParams

Modifications

  • Add new Customization for OperationCOntextParams

Testing

  • Added Junits
  • Also generated S3 code and made sure it compiles with newly added code.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

License

  • I confirm that this pull request can be released under the Apache 2 license
    private static void setOperationContextParams(S3EndpointParams.Builder params, String operationName, SdkRequest request) {
        switch (operationName) {
        case "DeleteObjects":
            setOperationContextParams(params, (DeleteObjectsRequest) request);
            break;
        default:
            break;
        }
    }
    private static void setOperationContextParams(S3EndpointParams.Builder params, DeleteObjectsRequest request) {
        // TODO: Add JMESPathRuntime for Delete.Objects[*].key
        params.deleteObjectKeys(new ArrayList<>());
    }

@joviegas joviegas requested a review from a team as a code owner April 26, 2024 20:18
@joviegas joviegas force-pushed the joviegas/customizeOPerationParams_forS3 branch from 40f1e19 to c5763e2 Compare April 29, 2024 16:10
…tion Context params and adding customizations for S3""

This reverts commit 5fbba7a.
@joviegas joviegas force-pushed the joviegas/customizeOPerationParams_forS3 branch from c5763e2 to c60dc43 Compare April 29, 2024 16:55
@joviegas joviegas force-pushed the joviegas/customizeOPerationParams_forS3 branch from 3822b4f to f898582 Compare April 30, 2024 03:29
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@joviegas joviegas merged commit 5bb2346 into feature/StringArrayEndpointParams Apr 30, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants