Add ADAPTIVE_V2 retry mode to support the legacy behavior #5123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugmanue
changed the title
|
dagnir
reviewed
Apr 30, 2024
Comment on lines
88
to
89
| * from remembering its state across requests which is needed to correctly estimate its sending rate. Given that the | ||
| * this bug has been present since its introduction and that correct version might change the traffic patterns of the SDK we |
| * @deprecated As of 2.25.xx, replaced by {@link #ADAPTIVE_V2}. The ADAPTIVE implementation has a bug that prevents it | ||
| * from remembering its state across requests which is needed to correctly estimate its sending rate. Given that the | ||
| * this bug has been present since its introduction and that correct version might change the traffic patterns of the SDK we | ||
| * deemed too risky to fix this implementation.. |
Comment on lines
101
to
105
| * Adaptive V2 mode differs from {@link #ADAPTIVE} mode in the computed delays between calls, including the fist attempt | ||
| * that might be delayed if the algorithm considers that it's needed to increase the odds of a successful response. The | ||
| * previous Adaptive mode is also designed to work like so but a bug present since its introduction prevents it from | ||
| * preserving its internal state across requests. | ||
| * <p> |
There was a problem hiding this comment.
s/fist/first/
Also should "Adaptive" be capitalized?
The
* previous Adaptive mode is also designed to work like so but a bug present since its introduction prevents it from
* preserving its internal state across requests.
I don't think it's necessary to specify that ADAPTIVE is also supposed to work this. If we link back to ADAPTIVE from here I think that's sufficient
Comment on lines
116
to
119
| if (retryMode == RetryMode.ADAPTIVE_V2) { | ||
| throw new UnsupportedOperationException("ADAPTIVE_V2 is not supported by retry policies, use a RetryStrategy " | ||
| + "instead"); | ||
| } |
There was a problem hiding this comment.
Can we move this check to Builder instead?
There was a problem hiding this comment.
I moved this to the builder, not sure what's the reason behind it but I guess it's the same.
dagnir
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change is aimed to prevent breaking existing users of the legacy adaptive mode while introducing the means needed for new users to onboard and use the correct adaptive implementation.
Modifications
This change introduces a new
RetryModeconstant,ADAPTIVE_V2and uses the legacyADAPTIVEretry policy by adapting it to a retry strategy using the existing adapter when theADAPTIVEmode is requested, either by usingAwsRetryStrategy.forRetryMode(RetryMode.ADAPTIVE)call, or by setting theretry_mode=adaptivevalue in the profile file or by using theaws.retryMode=ADAPTIVEsystem setting.Customers that need or want the correct adaptive mode will need to use instead
RetryMode.ADAPTIVE_V2. This will reduce the risk of breaking customers that are using the legacy mode.Testing
Added unit tests to validate that all the current ways of configuring the retry logic in the SDK will create the expected and correct instance that implements the desired logic.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License