Modify SDK to not fail on invalid Expires header

[anirudh9391]

Implementing a SEP to modify behavior while parsing S3 Expires header.

Motivation and Context

• SEP to implement an alternate way of unmarshalling exception handling for the "Expires" header.

Modifications

• SDKs will not throw an exception if an invalid expires header is present.
• "Expires" header will be defined as a timestamp regardless of any changes to its model definition.

Testing

Defined a custom unit test and validated by running it once. Source code

    @Test
    void test() throws IOException {

        String bucketName = "anirudkr-bucket-2";
        String key = "key1.txt";

        //File file = new RandomTempFile(10_000);
        S3Client client = S3Client.builder().build();

        //PutObjectRequest put = PutObjectRequest.builder().bucket(bucketName).key(key).expires(Instant.now()).build();
        //client.putObject(put, file.toPath());

        LogCaptor logCaptor = LogCaptor.create();

        HeadObjectRequest request = HeadObjectRequest.builder().bucket(bucketName).key(key).build();
        Assertions.assertThatCode(() -> client.headObject(request))
                  .doesNotThrowAnyException();
        assertTrue(client.headObject(request).expires() == null);
        assertTrue(client.headObject(request).expiresString() != null);

        List<LogEvent> events = logCaptor.loggedEvents();
        String expected = "Invalid datetime format provided in the Expires field 2034-01-01T00:00:00Z";
    }

Runs successfully.

The Expires header on this bucket is an invalid format
2034-01-01T00:00:00Z

Test validates

1. exception is not logged
2. warning is thrown

Screenshots (if appropriate)

Types of changes

• [x ] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

[L-Applin]

I don't see the mentioned unit test in the added code? Also, should we add unit-test the HeaderUnmarshaller.INSTANT un-marshaller?

[L-Applin]

I think we should include a codegen test for the added trait

[anirudh9391]

I don't see the mentioned unit test in the added code? Also, should we add unit-test the HeaderUnmarshaller.INSTANT un-marshaller?

Im working on the wiremock tests. I think the wiremock should cover the code path

I don't see the mentioned unit test in the added code? Also, should we add unit-test the HeaderUnmarshaller.INSTANT un-marshaller?

Im working on the wiremock tests, should publish that along with the next revision.

[sonarcloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud