Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Progress Listener Invocation methods to Asynchronous code paths #5044

Open
wants to merge 48 commits into
base: feature/anirudkr-progress-listener
Choose a base branch
from

Conversation

anirudh9391
Copy link
Contributor

Asynchronous request Path to include Progress Listener invocations to track transactions

Motivation and Context

This is a parity feature gap between 1.x and 2.x

Modifications

Added callbacks :

  • requestPrepared
  • requestBytesSent
  • responseHeaderReceived
  • responseBytesReceived

in asynchronous code path.

Testing

Unit Tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)

Checklist

  • [x ] I have read the CONTRIBUTING document
  • [x ] Local run of mvn install succeeds
  • [ x] My code follows the code style of this project
  • [x ] My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • [ x] I have added tests to cover my changes
  • [x ] All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [ x] I confirm that this pull request can be released under the Apache 2 license

…ure context objects. Added progress listener method to RequestOverrideConfiguration
@anirudh9391 anirudh9391 requested a review from a team as a code owner March 26, 2024 02:28
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76.6% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint


public BytesSentTrackingPublisher(Publisher<ByteBuffer> upstream,
ProgressUpdater progressUpdater,
Optional<Long> contentLength) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants