New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HostPrefix in E2.0, enable E2.0 for all services #3564
Conversation
b0a4a97
to
be3658b
Compare
Here's an example generated client test from the new SyncTestCase("For region eu-central-1 with FIPS enabled and DualStack enabled", () -> {
LocationClientBuilder builder = LocationClient.builder();
builder.credentialsProvider(BaseRuleSetClientTest.CREDENTIALS_PROVIDER);
builder.httpClient(getSyncHttpClient());
builder.fipsEnabled(true);
builder.region(Region.of("eu-central-1"));
builder.dualstackEnabled(true);
CreateGeofenceCollectionRequest request = CreateGeofenceCollectionRequest.builder().build();
builder.build().createGeofenceCollection(request);
},
Expect.builder()
.endpoint(Endpoint.builder().url(URI.create("https://geofencing.geo-fips.eu-central-1.api.aws")).build())
.build()),
|
...src/main/java/software/amazon/awssdk/codegen/poet/rules/EndpointResolverInterceptorSpec.java
Show resolved
Hide resolved
...src/main/java/software/amazon/awssdk/codegen/poet/rules/EndpointResolverInterceptorSpec.java
Show resolved
Hide resolved
...c/test/resources/software/amazon/awssdk/codegen/poet/rules/endpoint-resolve-interceptor.java
Outdated
Show resolved
Hide resolved
This changes fixes the previously incorrect handling of `hostPrefix` in services, causing requests for some services to have the wrong URL. This change also undoes the suppression of rules-based endpoint generation for all services apart from EventBridge, S3, and S3 Control, which was implemented in #3520 because of the previously mentioned `hostPrefix` issue.
a4abaa1
to
55c14ed
Compare
55c14ed
to
b6b6450
Compare
SonarCloud Quality Gate failed. |
Motivation and Context
This changes fixes the previously incorrect handling of
hostPrefix
in services, causing requests for some services to have the wrong URL. This change also undoes the suppression of rules-based endpoint generation for all services apart from EventBridge, S3, and S3 Control, which was implemented in #3520 because of the previously mentionedhostPrefix
issue.Modifications
useRuleBasedEndpoints
customization, enabling rules based endpoints for all services again.hostPrefix
if necessaryhostPrefix
Testing
hostPrefix
to the requests. i.e. if the operation being called has ahostPrefix
, the expected URL is updated to also include thathostPrefix
.hostPrefix
such aslocation
andevidently
.RunningInteg testsScreenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License