Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DynamoDbIgnoreNulls to support ignoreNulls in nested beans #2397

Merged
merged 2 commits into from Apr 13, 2021

Conversation

zoewangg
Copy link
Contributor

Description

Add DynamoDbIgnoreNulls to support ignoreNulls in nested beans

Motivation and Context

#2303

Testing

Added tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@@ -203,6 +206,19 @@ private BeanTableSchema(StaticTableSchema<T> staticTableSchema) {
return builder.build();
}

private static AttributeConfiguration resolveAttributeConfiguration(PropertyDescriptor propertyDescriptor) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this encapsulation of the configuration settings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@bmaizels bmaizels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are all non-binding/blocking.

@@ -203,6 +206,19 @@ private BeanTableSchema(StaticTableSchema<T> staticTableSchema) {
return builder.build();
}

private static AttributeConfiguration resolveAttributeConfiguration(PropertyDescriptor propertyDescriptor) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

93.4% 93.4% Coverage
3.0% 3.0% Duplication

@zoewangg zoewangg merged commit df22f81 into master Apr 13, 2021
@zoewangg zoewangg deleted the zoewang/ignoreNulls branch April 13, 2021 17:59
aws-sdk-java-automation added a commit that referenced this pull request Feb 21, 2023
…5d5f5142e

Pull request: release <- staging/34060778-53d5-4c69-b9a7-2c75d5f5142e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants