New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DynamoDbIgnoreNulls to support ignoreNulls in nested beans #2397
Conversation
@@ -203,6 +206,19 @@ private BeanTableSchema(StaticTableSchema<T> staticTableSchema) { | |||
return builder.build(); | |||
} | |||
|
|||
private static AttributeConfiguration resolveAttributeConfiguration(PropertyDescriptor propertyDescriptor) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this encapsulation of the configuration settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments are all non-binding/blocking.
...m/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/EnhancedType.java
Show resolved
Hide resolved
@@ -203,6 +206,19 @@ private BeanTableSchema(StaticTableSchema<T> staticTableSchema) { | |||
return builder.build(); | |||
} | |||
|
|||
private static AttributeConfiguration resolveAttributeConfiguration(PropertyDescriptor propertyDescriptor) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
...-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/mapper/BeanTableSchema.java
Outdated
Show resolved
Hide resolved
1a11a61
to
22e9562
Compare
Kudos, SonarCloud Quality Gate passed! |
…5d5f5142e Pull request: release <- staging/34060778-53d5-4c69-b9a7-2c75d5f5142e
Description
Add
DynamoDbIgnoreNulls
to support ignoreNulls in nested beansMotivation and Context
#2303
Testing
Added tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsLicense