Allow clients to specify the request date on signing requests #5239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main intent of this PR is to make the signed urls api flexible with regards to the time when it's created.
GOAL: implement what it's called
Cacheable signed URLs
. Usingv4
presign method, the currentDate
is necessary. Meaning that we can't generate constantsigned urls
according to our needs.example: we want to avoid certain customers to download again and again the same set of images. And we don't want to make those images publicly available. If those images have a
Control-Cache: private, max-age=3600
policy, it won't be used since each time we sign URLs those will be completely different. Therefore the browser won't be able to re-use them.original idea: https://advancedweb.hu/cacheable-s3-signed-urls/