codegen: Add fix to prevent HTTP/2 event stream request hang on error #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds fix addressing an issue where SDK's bi-directional eventstream API operation request could hang when the HTTP/2 stream was closed by the service with a non-200 status code. Go 1.15 through 1.17 have an issue where the HTTP/2 request can hang while waiting for the HTTP response, and input payload reader. The Expect: 100-Continue workaround forces the HTTP client to wait for a `100 continue` or other HTTP status code before attempting to wait for the request's body to be read. This workaround is not needed for Go 1.18, as a fix to the HTTP client resolves this issue. Related to aws/aws-sdk-go-v2#1515
skmcgrail
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fix addressing an issue where SDK's bi-directional eventstream API operation request could hang when the HTTP/2 stream was closed by the service with a non-200 status code.
Go 1.15 through 1.17 have an issue where the HTTP/2 request can hang while waiting for the HTTP response, and input payload reader. The Expect: 100-Continue workaround forces the HTTP client to wait for a
100 continueor other HTTP status code before attempting to wait for the request's body to be read. This workaround is not needed for Go1.18, as a fix to the HTTP client resolves this issue.
Fixes
services/lexruntimev2andservice/transcribestreamingserviceeventstream operations.Related to aws/aws-sdk-go-v2#1515