Add missing fields for config test. #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
approved these changes
Feb 19, 2021
|
Thanks for creating the additional test cases for the Config's merge behavior. We'll get this merged in to the SDK to ensure regressions don't happen in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actualy, I wanna fix the
LowerCaseHeaderMapsissue, its' an important config for the users who are using Metadata, related to #445.The
unmarshalHeaderMapmethod always returns the canonical header key form, but before this PR #3671, theLowerCaseHeaderMapsconfig didn't work, so I tried to debug it and I found there's a bug inmergeInConfigmethod, now it has been fixed, so just add some tests.