Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/sync: Remove unstable single flight tests #3355

Closed
wants to merge 1 commit into from
Closed

internal/sync: Remove unstable single flight tests #3355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/sync/singleflight/singleflight_test.go
View file
Open in desktop
Expand Up @@ -41,6 +41,8 @@ func TestDoErr(t *testing.T) {
}

func TestDoDupSuppress(t *testing.T) {
t.Skip("unable test")

var g Group
var wg1, wg2 sync.WaitGroup
c := make(chan string, 1)
Expand Down Expand Up @@ -89,6 +91,8 @@ func TestDoDupSuppress(t *testing.T) {
// Test that singleflight behaves correctly after Forget called.
// See https://github.com/golang/go/issues/31420
func TestForget(t *testing.T) {
t.Skip("unable test")

var g Group

var firstStarted, firstFinished sync.WaitGroup
Expand Down